fix: repair failing tests across utility library#232
Open
stooit wants to merge 1 commit into
Open
Conversation
- calculator: divide throws on division by zero - date-utils: formatRelative rounds hours-to-days (fixes off-by-one) - string-utils: implement wordCount multi-space handling and truncate - task-manager: implement remove/update/sortBy methods - validator: fix isEmail long-TLD and isUrl port handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 failing tests across the library. All 60 tests now pass (0 fail). No test files modified, no dependencies added.
Changes
src/calculator.ts—dividenow throwsError("Division by zero")when the divisor is0(previously returnedInfinity).src/date-utils.ts—formatRelativeusesMath.roundinstead ofMath.floorfor the hours→days conversion, fixing the off-by-one (36h now → "2 days ago").src/string-utils.ts— implementedwordCountcollapsing of multiple consecutive spaces, and thetruncateword-boundary logic (ellipsis counts towardmaxLength).src/task-manager.ts— implemented the missing/incompleteremove,update, andsortBy(priority andcreatedAt) methods.src/validator.ts—isEmailnow accepts long TLDs (e.g.user@example.museum);isUrlnow accepts URLs with a port (e.g.http://localhost:3000).Verification
bun test→ 60 pass / 0 fail.Assumptions
truncatewithmaxLength <= ellipsis.length) were left untouched to avoid altering the established contract.