Make TypedArray.prototype.includes conform to spec#1068
Merged
bnoordhuis merged 1 commit intoquickjs-ng:masterfrom May 25, 2025
Merged
Make TypedArray.prototype.includes conform to spec#1068bnoordhuis merged 1 commit intoquickjs-ng:masterfrom
bnoordhuis merged 1 commit intoquickjs-ng:masterfrom
Conversation
In the case of typed arrays backed by resizable arraybuffers, searching for `undefined` matches if the search index is in bounds with respect to the typed array's original length.
bnoordhuis
force-pushed
the
fix-ta-includes
branch
from
7da3cb5 to
a5d6af5
Compare
Contributor
Author
|
Weird, GH thinks I closed the PR even though I only force-pushed to my branch. |
saghul
approved these changes
May 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the case of typed arrays backed by resizable arraybuffers, searching for
undefinedmatches if the search index is in bounds with respect to the typed array's original length.