Add support for import attributes and JSON modules#1300
Conversation
| JSModuleLoaderFunc *module_loader, void *opaque); | ||
|
|
||
| /* same as JS_SetModuleLoaderFunc but with import attributes support */ | ||
| JS_EXTERN void JS_SetModuleLoaderFunc2(JSRuntime *rt, |
There was a problem hiding this comment.
Q: do we want to keep the 2 suffix function a la bellard or make it the one and only loader function?
There was a problem hiding this comment.
No super strong opinion. A polygamist would say "two is better than one", a programmer the inverse. What would a polygamous programmer say though?
If you want me to make the call: only one.
saghul
force-pushed
the
import-attrs-json
branch
from
66f4787 to
3357c2a
Compare
| cstr = JS_AtomToCStringLen(ctx, &cstr_len, tab[i].atom); | ||
| if (!cstr) { | ||
| ret = -1; | ||
| break; | ||
| } | ||
| if (!(cstr_len == 4 && !memcmp(cstr, "type", cstr_len))) { | ||
| JS_ThrowTypeError(ctx, "import attribute '%s' is not supported", cstr); | ||
| ret = -1; | ||
| } | ||
| JS_FreeCString(ctx, cstr); |
There was a problem hiding this comment.
Future enhancement (because there are lots of places where we have this kind of atom-to-string munging):
bool JS_AtomStrEq(JSRuntime *rt, JSAtom atom, const char *s, size_t n);Name TBD and I suppose for parity you'd also want one to compare atomized integers.
| JSModuleLoaderFunc *module_loader, void *opaque); | ||
|
|
||
| /* same as JS_SetModuleLoaderFunc but with import attributes support */ | ||
| JS_EXTERN void JS_SetModuleLoaderFunc2(JSRuntime *rt, |
There was a problem hiding this comment.
No super strong opinion. A polygamist would say "two is better than one", a programmer the inverse. What would a polygamous programmer say though?
If you want me to make the call: only one.
saghul
force-pushed
the
import-attrs-json
branch
from
3357c2a to
944720e
Compare
|
I had a change of heart and chose to keep both the old and the new APIs. We can revisit later. |
2 participants
Ref: bellard/quickjs@f10ef29