Conversation
Contributor
Author
|
Argh, when miving the test into the suite we don't seem to expose gc, lemme check... |
js_mapped_arguments_mark was calling mark_func on non-detached var_refs, which are not GC objects. Fixes: #1400
bnoordhuis
approved these changes
Mar 12, 2026
| /* mapped arguments with GC must not crash (non-detached var_refs) */ | ||
| function f3(a) { | ||
| arguments; | ||
| gc(); |
Contributor
There was a problem hiding this comment.
FTR, can also be invoked through std.gc().
Contributor
Author
There was a problem hiding this comment.
In run262 we don't seem to load std so when running with make test I got a reference error, since I thought we might not want to add std there,, I went with the smallest change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
js_mapped_arguments_mark was calling mark_func on non-detached var_refs,
which are not GC objects.
Fixes: #1400