Better output from JS_ToCString() on exception#274
Merged
bnoordhuis merged 1 commit intoquickjs-ng:masterfrom Feb 19, 2024
Merged
Better output from JS_ToCString() on exception#274bnoordhuis merged 1 commit intoquickjs-ng:masterfrom
bnoordhuis merged 1 commit intoquickjs-ng:masterfrom
Conversation
`ToString(object)` can fail when there is a pending exception. Add a special case for exception objects to help debugging. Getting an empty string when the real error was "InternalError: stack overflow" is rage inducing. Fixes: quickjs-ng#273
Contributor
Author
|
Oh, I guess it does. I'll go and close that one. |
saghul
pushed a commit
that referenced
this pull request
Apr 4, 2025
saghul
pushed a commit
that referenced
this pull request
Apr 4, 2025
cuiweixie
pushed a commit
to cuiweixie/quickjs
that referenced
this pull request
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ToString(object)can fail when there is a pending exception. Add a special case for exception objects to help debugging. Getting an empty string when the real error was "InternalError: stack overflow" is rage inducing.Fixes: #273
I couldn't really think of a good way to test this but I can say it works well in a project where I was getting rage induced.