Build and run run-test262 on Windows#579
Build and run run-test262 on Windows#579bnoordhuis wants to merge 1 commit intoquickjs-ng:masterfrom
Conversation
a6c7c8e to
960a739
Compare
|
I don't understand why msbuild isn't building run-test262 when it's building e.g. function_source.exe just fine.... you have any ideas, @saghul? I guess I'll remove the conditional in CMakeLists.txt as an experiment and see what happens. |
|
@bnoordhuis On Windows we build targets one at a time for some reason: And the run-262 target is not there. I'd suggest trying to build'em all! If that doesn't work, just add the extra cmake incantation... |
|
You can land this: #583 Then a rebase and it should do. CMake is weird :-P |
a31db3f to
67423a3
Compare
|
It's well-hidden in the wall of text but indeed, no Imma cross that bridge come what may. |
7ccdec2 to
ef955a9
Compare
Windows line endings 🤦 But hey, it's progress of a kind. |
|
Good progress! 💪 |
7480749 to
c0c0107
Compare
|
I'm kinda stuck. UNIX-vs.-Windows newlines don't seem to be the reason why the tests are failing, but it's still complaining "unexpected error: foo, previous error: foo" I suppose it doesn't matter for running local tests (no expected errors, everything should pass) but still... Doesn't happen with mingw-under-wine, by the way; that is, I can't reproduce locally. |
|
I'll give it a try too. |
c0c0107 to
6a72331
Compare
|
I think enough of this landed through other pull requests that this one can be closed now. |
|
I've been a tad short on time this past week, hope to give it a go soon. |
The ulterior motive here is not that I want to increase CI times further but that I want to repurpose run-test262 for running our own tests.
I fully expect msvc to not ship
<ftw.h>but we'll cross that bridge when we get to it.