Skip to content

Build and run run-test262 on Windows#579

Closed
bnoordhuis wants to merge 1 commit intoquickjs-ng:masterfrom
bnoordhuis:run-test262-win32
Closed

Build and run run-test262 on Windows#579
bnoordhuis wants to merge 1 commit intoquickjs-ng:masterfrom
bnoordhuis:run-test262-win32

Conversation

@bnoordhuis
Copy link
Copy Markdown
Contributor

The ulterior motive here is not that I want to increase CI times further but that I want to repurpose run-test262 for running our own tests.


I fully expect msvc to not ship <ftw.h> but we'll cross that bridge when we get to it.

@bnoordhuis
Copy link
Copy Markdown
Contributor Author

I don't understand why msbuild isn't building run-test262 when it's building e.g. function_source.exe just fine.... you have any ideas, @saghul?

I guess I'll remove the conditional in CMakeLists.txt as an experiment and see what happens.

@saghul
Copy link
Copy Markdown
Contributor

saghul commented Oct 8, 2024

@bnoordhuis On Windows we build targets one at a time for some reason:

      - name: build
        run: |
          cmake -B build -DBUILD_EXAMPLES=ON -G "Visual Studio 17 2022" -A ${{matrix.arch}}
          cmake --build build --config ${{matrix.buildType}} --target qjs_exe
          cmake --build build --config ${{matrix.buildType}} --target function_source
          cmake --build build --config ${{matrix.buildType}} --target fib
          cmake --build build --config ${{matrix.buildType}} --target point

And the run-262 target is not there. I'd suggest trying to build'em all! cmake --build build --config ${{matrix.buildType}}

If that doesn't work, just add the extra cmake incantation...

@saghul
Copy link
Copy Markdown
Contributor

saghul commented Oct 8, 2024

You can land this: #583

Then a rebase and it should do.

CMake is weird :-P

@bnoordhuis
Copy link
Copy Markdown
Contributor Author

It's well-hidden in the wall of text but indeed, no <ftw.h>...

2024-10-08T19:50:46.5661398Z D:\a\quickjs\quickjs\run-test262.c(34,1): error C1083: Cannot open include file: 'ftw.h': No such file or directory [D:\a\quickjs\quickjs\build\run-test262.vcxproj]

Imma cross that bridge come what may.

@bnoordhuis
Copy link
Copy Markdown
Contributor Author

test262/test/built-ins/AsyncFromSyncIteratorPrototype/throw/throw-undefined-poisoned-return.js:68: strict mode: unexpected error: TypeError: $DONE() not called
test262/test/built-ins/AsyncFromSyncIteratorPrototype/throw/throw-undefined-poisoned-return.js:68: strict mode: previous error: TypeError: $DONE() not called

Windows line endings 🤦

But hey, it's progress of a kind.

@saghul
Copy link
Copy Markdown
Contributor

saghul commented Oct 9, 2024

Good progress! 💪

@bnoordhuis
Copy link
Copy Markdown
Contributor Author

I'm kinda stuck. UNIX-vs.-Windows newlines don't seem to be the reason why the tests are failing, but it's still complaining "unexpected error: foo, previous error: foo"

I suppose it doesn't matter for running local tests (no expected errors, everything should pass) but still...

Doesn't happen with mingw-under-wine, by the way; that is, I can't reproduce locally.

@saghul
Copy link
Copy Markdown
Contributor

saghul commented Oct 10, 2024

I'll give it a try too.

@bnoordhuis
Copy link
Copy Markdown
Contributor Author

I think enough of this landed through other pull requests that this one can be closed now.

@bnoordhuis bnoordhuis closed this Oct 23, 2024
@bnoordhuis bnoordhuis deleted the run-test262-win32 branch October 23, 2024 11:07
@saghul
Copy link
Copy Markdown
Contributor

saghul commented Oct 23, 2024

I've been a tad short on time this past week, hope to give it a go soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants