Conversation
Contributor
Author
|
Alright, this is the last of the straightforward ones. The remaining ones: map, filter, take, drop, flatMap require creating a wrapping iterator AFAIS. Any pointers on how to go about it are most welcome! Perhaps we need a helper class a la async-from-sync iterator? |
bnoordhuis
approved these changes
Oct 25, 2024
Contributor
|
W.r.t. wrapping iterators: I imagine you add a new The class probably needs to be defined as such: ctx->class[JS_CLASS_ITERATOR_HELPER] = JS_NewObjectProto(ctx, ctx->iterator_proto);And have .next and .return methods that call the methods of the same name on the wrapped object (edit: and have mark and finalize callbacks.) |
Contributor
Author
|
That's what I had in mind. Great, I'll try to give it a go this week! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.