Improve line:column tracking#660
Merged
bnoordhuis merged 2 commits intoquickjs-ng:masterfrom Nov 7, 2024
Merged
Conversation
Emit source locations manually for more precise tracking. Don't infer them from emitted bytecode opcodes because that leads to inaccurate and sometimes surprising results. Speeds up code generation (although infinitesimally) as a bonus. Fixes: quickjs-ng#236
bnoordhuis
commented
Nov 7, 2024
|
|
||
| try { | ||
| throw new Error(""); // line 10, column 19 | ||
| throw new Error(""); // line 10, column 15 |
Contributor
Author
There was a problem hiding this comment.
This change is because we now point to new instead of Error, like V8 and other engines do.
saghul
approved these changes
Nov 7, 2024
Contributor
saghul
left a comment
saghul
left a comment
There was a problem hiding this comment.
Really, this is it?! Awesome! 👏 I think you can probably close the other PR too.
Contributor
|
Thank you Ben! 💥 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emit source locations manually for more precise tracking. Don't infer them from emitted bytecode opcodes because that leads to inaccurate and sometimes surprising results.
Speeds up code generation (although infinitesimally) as a bonus.
Fixes: #236
I initially planned to open this as a draft but in my (admittedly light) testing it works remarkably well. We now emit the exact same stack trace for the test case from #236.