Remove unnecessary parameters#708
Merged
saghul merged 1 commit intoquickjs-ng:masterfrom Nov 20, 2024
Merged
Conversation
Enhanced msvc cross-compile compatibility
Contributor
|
Can you clarify how this helps? |
Contributor
Author
This msvc version of the function does not depend on tz, tz was introduced (and not used) in the linux version of the function, where if it was for binary compatibility I think it could be retained but the function name has changed and there is no binary compatibility issue. Then in a cross-compiled environment it even brings some compiler alerts |
Contributor
Author
|
And in linux the tz parameter is only used in the kernel, so I think it's possible to remove the unnecessary parameter |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhanced msvc cross-compile compatibility