Fix compilation of quickjs-libc under emscripten#773
Merged
saghul merged 2 commits intoquickjs-ng:masterfrom Dec 27, 2024
Merged
Fix compilation of quickjs-libc under emscripten#773saghul merged 2 commits intoquickjs-ng:masterfrom
saghul merged 2 commits intoquickjs-ng:masterfrom
Conversation
Contributor
|
Can you use the same guard used in cutils.h ? |
Contributor
Author
Done! |
saghul
approved these changes
Dec 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The addition of
js_oncecalls tojs_os_execis causing compilation errors under emscripten with:This PR just gates the initialisation behind
ifdefsso that it falls back to the non-threaded codepath gracefully.I've also added quickjs-libc to the emscripten CI so that the changes are tested.
Thanks!