Simplify exiting interpreter with exception#789
Merged
Conversation
saghul
force-pushed
the
simplify-exception-exit
branch
2 times, most recently
from
6a0624a to
196c0b4
Compare
Contributor
Author
|
I just had an idea change things a bit more, will post an update. |
- Avoid keeping the exception object around - Avoid passing the responsibility of freeing the exeption object to the caller
saghul
force-pushed
the
simplify-exception-exit
branch
from
196c0b4 to
1bf7525
Compare
Contributor
Author
|
@bnoordhuis PTAL, I think it's a cleaner implementation now, and more "backwars compatible" as in, code that calls |
saghul
commented
Jan 8, 2025
| JS_FreeValue(ctx, ret); | ||
| JS_FreeContext(ctx); | ||
| js_std_free_handlers(rt); | ||
| JS_FreeContext(ctx); |
Contributor
Author
There was a problem hiding this comment.
I reversed the order here since I noticed that's how qjs.c does it.
bnoordhuis
approved these changes
Jan 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.