Skip to content

Fix uncatchable error inside a promise (#810)#811

Merged
saghul merged 1 commit intoquickjs-ng:masterfrom
laishere:master
Jan 20, 2025
Merged

Fix uncatchable error inside a promise (#810)#811
saghul merged 1 commit intoquickjs-ng:masterfrom
laishere:master

Conversation

@laishere
Copy link
Copy Markdown
Contributor

Fix issue #810

@saghul
Copy link
Copy Markdown
Contributor

saghul commented Jan 10, 2025

It would be good to have a test for this.

@laishere
Copy link
Copy Markdown
Contributor Author

How to run all the tests? @saghul

I just ran

run-test262.exe tests.conf

Result: 0/29 errors, 3 excluded

Cannot run test262.conf.

BTW, I should add my test.js to tests directory right?

@saghul
Copy link
Copy Markdown
Contributor

saghul commented Jan 10, 2025

This wouldn't be a 262 test, so yeah adding it to the tests/ directory is the way.

@laishere
Copy link
Copy Markdown
Contributor Author

laishere commented Jan 10, 2025

I just realized that we need an interrupt handler to test it. So I can't do it in pure js. So would need a separate test or modify run-test262.c

@saghul
Copy link
Copy Markdown
Contributor

saghul commented Jan 10, 2025

Yes it would likely need to be its own C file with the simplified test.

@laishere
Copy link
Copy Markdown
Contributor Author

Should I add Makefile and CMakeLists.txt target for this test? @saghul

@saghul
Copy link
Copy Markdown
Contributor

saghul commented Jan 10, 2025

CMake should be the only requirement, since it shouldn't have EXCLUDE_FROM_ALL

@laishere laishere requested a review from saghul January 10, 2025 14:00
@saghul
Copy link
Copy Markdown
Contributor

saghul commented Jan 17, 2025

Looking good! Can you pl run the test from the CI files? Building it won't make it run.

@laishere
Copy link
Copy Markdown
Contributor Author

Sure!

@laishere
Copy link
Copy Markdown
Contributor Author

Updated.

@saghul
Copy link
Copy Markdown
Contributor

saghul commented Jan 17, 2025

Can you please add it to (some of) the windows targets?

@laishere
Copy link
Copy Markdown
Contributor Author

No problem, I am working on it now!

@laishere
Copy link
Copy Markdown
Contributor Author

Updated.

Copy link
Copy Markdown
Contributor

@saghul saghul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nice work! @bnoordhuis can you have a quick look?

@laishere
Copy link
Copy Markdown
Contributor Author

Updated.

@saghul saghul merged commit 11b7592 into quickjs-ng:master Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants