Remove trailing zero-size arrays from JSString#930
Merged
bnoordhuis merged 2 commits intoquickjs-ng:masterfrom Feb 25, 2025
Merged
Remove trailing zero-size arrays from JSString#930bnoordhuis merged 2 commits intoquickjs-ng:masterfrom
bnoordhuis merged 2 commits intoquickjs-ng:masterfrom
Conversation
It's been reported that UBSan's `-fsanitize=bounds-strict` does not like empty arrays. Remove them and replace their uses with old school pointer arithmetic. Fixes: quickjs-ng#928
Contributor
Author
|
For posterity, the build error is a false positive ( Details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's been reported that UBSan's
-fsanitize=bounds-strictdoes not like empty arrays. Remove them and replace their uses with old school pointer arithmetic.Fixes: #928
I had to remove function argument const-ness in a number of places. It was either that or introduce additional
str8_candstr16_cfunctions, but that's both more work and more to remember.If you think it's a good approach, I'll run benchmarks to see if it doesn't regress performance. (It shouldn't, but hey, compilers.)