Skip to content

refactor: replace strip-ansi with native module#2521

Merged
szymonrybczak merged 1 commit into
react-native-community:mainfrom
stianjensen:remove-strip-ansi
Feb 4, 2025
Merged

refactor: replace strip-ansi with native module#2521
szymonrybczak merged 1 commit into
react-native-community:mainfrom
stianjensen:remove-strip-ansi

Conversation

@stianjensen

Copy link
Copy Markdown
Contributor

Inspired by eslint/eslint#18982

This API is built-in since node 16.11. react-native-cli already requires node 18 as of last year.

@szymonrybczak szymonrybczak left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stianjensen

Copy link
Copy Markdown
Contributor Author

Not sure if this windows snapshot diff could be related to this PR or not?

@szymonrybczak

Copy link
Copy Markdown
Collaborator

@stianjensen not really, failure on E2E Windows pipeline was caused by other change that landed on main branch. This PR should be good to merge 👍

@github-actions

github-actions Bot commented Feb 4, 2025

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 3 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.

@github-actions github-actions Bot added the stale label Feb 4, 2025
Inspired by eslint/eslint#18982

This API is built-in since node 16.11. react-native-cli already requires
node 18 as of last year.
@szymonrybczak szymonrybczak merged commit 0dcdcc6 into react-native-community:main Feb 4, 2025
@stianjensen stianjensen deleted the remove-strip-ansi branch February 4, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants