chore: migrate from chalk to picocolors#2631
Conversation
this only disables the colouring, not formatting functions (e.g. bold).
Rexogamer
requested review from
cipolleschi,
cortinico,
szymonrybczak and
thymikee
as code owners
szymonrybczak
left a comment
szymonrybczak
left a comment
There was a problem hiding this comment.
Nice, thank you! 👌
|
rebased; should be mergeable |
|
There hasn't been any activity on this pull request in the past 3 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. |
|
will rebase this soon |
|
okay this should be ready |
|
There hasn't been any activity on this pull request in the past 3 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. |
|
(I can't currently see if there are any conflicts but assuming any are fixed) is this likely to be merged? |
|
yup, we should be able to merge it once conflicts are resolved :) |
Really feels like these two contradict eachother 🤔 |
|
this should be ready now :3 |
|
Thank you @Rexogamer! |
4 participants
Summary
picocolorsis much smaller and slightly faster thanchalk. this PR migrates the various CLI packages topicocolors.Test Plan
yarn test- worked fine with one minor change (see review comments). the output should be identical.Checklist