Skip to content

breaking: Delete rawBody handling on /symbolicate endpoint#2637

Merged
thymikee merged 1 commit into
react-native-community:mainfrom
huntie:drop-symbolicate-handling
Apr 29, 2025
Merged

breaking: Delete rawBody handling on /symbolicate endpoint#2637
thymikee merged 1 commit into
react-native-community:mainfrom
huntie:drop-symbolicate-handling

Conversation

@huntie

@huntie huntie commented Mar 28, 2025

Copy link
Copy Markdown
Collaborator

Summary

This removes a longstanding hack that covered for a lack of JSON body parsing in Metro's /symbolicate endpoint. We're now resolving this in react/metro#1475 — meaning this can be removed from CLI.

Relevant changes:

Breaking: CLI will no longer intercept and populate req.rawBody on /symbolicate requests. Clients MUST send the header 'Content-Type': 'application/json'.

Test Plan

  • Build this repo via yarn build.
  • Link @react-native-community/cli-tools and @react-native-community/cli-server-api into a local checkout of react-native via yarn link.
  • ✅ Verify changed @react-native-community/cli-server-api/src/index.ts file in node_modules.
  • Open RNTester, modified to throw an error on launch.
image

✅ Correctly symbolicated thrown error

[Meta only] Also validated in D72063249.

Checklist

  • Documentation is up to date.
  • Follows commit message convention described in CONTRIBUTING.md.
  • For functional changes, my test plan has linked these CLI changes into a local react-native checkout (instructions).
@huntie huntie force-pushed the drop-symbolicate-handling branch from c37f4da to b3bb00e Compare April 28, 2025 13:52
@huntie huntie marked this pull request as ready for review April 29, 2025 14:08
@thymikee thymikee merged commit e4cd2c7 into react-native-community:main Apr 29, 2025
@huntie huntie deleted the drop-symbolicate-handling branch April 29, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants