Skip to content

Add missing @jest/globals dev dev to package.json#76

Open
mgcrea wants to merge 2 commits intoreact-native-community:mainfrom
mgcrea:patch-2
Open

Add missing @jest/globals dev dev to package.json#76
mgcrea wants to merge 2 commits intoreact-native-community:mainfrom
mgcrea:patch-2

Conversation

@mgcrea
Copy link
Copy Markdown
Contributor

@mgcrea mgcrea commented Nov 5, 2024

Summary:

Add missing @jest/globals dev dev to package.json

Changelog:

Test Plan:

@cortinico
Copy link
Copy Markdown
Member

Add missing @jest/globals dev dev to package.json

Why is this needed? Can you clarify?

@mgcrea
Copy link
Copy Markdown
Contributor Author

mgcrea commented Nov 5, 2024

Just created a new app and did have the error with the missing import from this line in my App.test.tsx:

import { it } from "@jest/globals";

But looking at the master it looks like it has been removed at some point.

I think it should be added back as it is required for TypeScript compatibility (see https://jestjs.io/docs/api)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants