Skip to content

PostCSS update and fix - #313

Open
stylesuxx wants to merge 7 commits into
react-webpack-generators:masterfrom
stylesuxx:master
Open

PostCSS update and fix#313
stylesuxx wants to merge 7 commits into
react-webpack-generators:masterfrom
stylesuxx:master

Conversation

@stylesuxx

Copy link
Copy Markdown
Contributor
  • Added template file for postcss config which provides infrastructure to add postcss plugins
  • Fixed and improved attachment of the postcss-loader to th webpack config
  • Updated README regarding postcss usage

Thanks to @sthzg for testing postcss and importLoader functionality.

Fixes #307

* Use newest template
* Updated Esprima
* Added template file for postcss config which provides infrastructure to add postcss plugins
* Fixed and improved attachment of the postcss-loader to th webpack config
* Updated README regarding postcss usage
@coveralls

coveralls commented Nov 25, 2016

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.05%) to 96.124% when pulling 0f89280 on stylesuxx:master into 9c68254 on react-webpack-generators:master.

@sthzg

sthzg commented Nov 25, 2016

Copy link
Copy Markdown
Member

@stylesuxx thanks for the updates. I will checkout the commit tonight and plan to manually test it in all variations (with all preprocessors with and without cssmodules). Yesterday I have tested it with CSS and LESS (both w/ and wo/ css modules), but I think it would be good to also check S(A|C)SS and Stylus once, especially to make sure that the @imports are picked up correctly.

As soon as that is done we can merge and publish a new V4 pre-release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants