Implement more missing methods on WithRuntimeDecorator#45049
Closed
neildhar wants to merge 2 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D58752127 |
Base commit: 2e03d26 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D58752127 |
neildhar
force-pushed
the
export-D58752127
branch
from
7d182a0 to
0c13bab
Compare
Summary: This PR adds missing `WithRuntimeDecorator` methods related to `NativeState`. This pattern is used by reanimated to ensure no concurrent access to the runtime. Without this `override` the `RuntimeDecorator` implementation was used, bypassing our mutex. ## Changelog: [GENERAL] [FIXED] - Add missing `NativeState` methods to the `WithRuntimeDecorator` class. Pull Request resolved: react#45042 Differential Revision: D58744051 Pulled By: neildhar
Summary: Pull Request resolved: react#45049 WithRuntimeDecorator is missing many methods that were added after it. Add implementations for them. The underlying issue here is that because this inherits from RuntimeDecorator, which implements all methods, there is no compilation error for this runtime when we add new methods. Changelog: [GENERAL] [FIXED] - Add missing methods to the WithRuntimeDecorator class. Reviewed By: avp Differential Revision: D58752127
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D58752127 |
neildhar
force-pushed
the
export-D58752127
branch
from
0c13bab to
dfdbec4
Compare
facebook-github-bot
pushed a commit
to facebook/hermes
that referenced
this pull request
Jun 26, 2024
Summary: X-link: react/react-native#45049 WithRuntimeDecorator is missing many methods that were added after it. Add implementations for them. The underlying issue here is that because this inherits from RuntimeDecorator, which implements all methods, there is no compilation error for this runtime when we add new methods. Changelog: [GENERAL] [FIXED] - Add missing methods to the WithRuntimeDecorator class. Reviewed By: avp Differential Revision: D58752127 fbshipit-source-id: d80b4ed1c38698ed3850d0cd961bf7ddde2449a0
Contributor
|
This pull request has been merged in 993f9fd. |
facebook-github-bot
pushed a commit
to facebook/hermes
that referenced
this pull request
Jun 26, 2024
Summary: X-link: react/react-native#45049 WithRuntimeDecorator is missing many methods that were added after it. Add implementations for them. The underlying issue here is that because this inherits from RuntimeDecorator, which implements all methods, there is no compilation error for this runtime when we add new methods. Changelog: [GENERAL] [FIXED] - Add missing methods to the WithRuntimeDecorator class. Reviewed By: avp Differential Revision: D58752127 fbshipit-source-id: d80b4ed1c38698ed3850d0cd961bf7ddde2449a0
kaseywolff
pushed a commit
to kaseywolff/hermes
that referenced
this pull request
Aug 20, 2024
Summary: X-link: react/react-native#45049 WithRuntimeDecorator is missing many methods that were added after it. Add implementations for them. The underlying issue here is that because this inherits from RuntimeDecorator, which implements all methods, there is no compilation error for this runtime when we add new methods. Changelog: [GENERAL] [FIXED] - Add missing methods to the WithRuntimeDecorator class. Reviewed By: avp Differential Revision: D58752127 fbshipit-source-id: d80b4ed1c38698ed3850d0cd961bf7ddde2449a0
This was referenced Sep 19, 2024
Flewp
pushed a commit
to discord/react-native-archived
that referenced
this pull request
Sep 19, 2024
Summary: Pull Request resolved: react#45049 WithRuntimeDecorator is missing many methods that were added after it. Add implementations for them. The underlying issue here is that because this inherits from RuntimeDecorator, which implements all methods, there is no compilation error for this runtime when we add new methods. Changelog: [GENERAL] [FIXED] - Add missing methods to the WithRuntimeDecorator class. Reviewed By: avp Differential Revision: D58752127 fbshipit-source-id: d80b4ed1c38698ed3850d0cd961bf7ddde2449a0
cipolleschi
pushed a commit
that referenced
this pull request
Feb 6, 2025
Summary: Pull Request resolved: #45049 WithRuntimeDecorator is missing many methods that were added after it. Add implementations for them. The underlying issue here is that because this inherits from RuntimeDecorator, which implements all methods, there is no compilation error for this runtime when we add new methods. Changelog: [GENERAL] [FIXED] - Add missing methods to the WithRuntimeDecorator class. Reviewed By: avp Differential Revision: D58752127 fbshipit-source-id: d80b4ed1c38698ed3850d0cd961bf7ddde2449a0
cipolleschi
pushed a commit
to facebook/hermes
that referenced
this pull request
Feb 6, 2025
Summary: X-link: react/react-native#45049 WithRuntimeDecorator is missing many methods that were added after it. Add implementations for them. The underlying issue here is that because this inherits from RuntimeDecorator, which implements all methods, there is no compilation error for this runtime when we add new methods. Changelog: [GENERAL] [FIXED] - Add missing methods to the WithRuntimeDecorator class. Reviewed By: avp Differential Revision: D58752127 fbshipit-source-id: d80b4ed1c38698ed3850d0cd961bf7ddde2449a0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
WithRuntimeDecorator is missing many methods that were added after it.
Add implementations for them.
The underlying issue here is that because this inherits from
RuntimeDecorator, which implements all methods, there is no compilation
error for this runtime when we add new methods.
Reviewed By: avp
Differential Revision: D58752127