Skip to content

Thinking-in-react-till-3rd-step#8

Merged
nafistiham merged 9 commits into
reactjs:mainfrom
nafistiham:thinking-in-react
May 4, 2023
Merged

Thinking-in-react-till-3rd-step#8
nafistiham merged 9 commits into
reactjs:mainfrom
nafistiham:thinking-in-react

Conversation

@nafistiham

Copy link
Copy Markdown
Collaborator

This is WIP. Creating a PR for simultaneous review. Please don't merge it before the whole page is done.

@github-actions

github-actions Bot commented May 1, 2023

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@moshfiqrony

Copy link
Copy Markdown
Collaborator

@nafistiham bhai make it draft from the next time. Then no one will be able to merge it but will be able to give review.

@nafistiham nafistiham marked this pull request as draft May 1, 2023 13:00
@nafistiham

Copy link
Copy Markdown
Collaborator Author

@nafistiham bhai make it draft from the next time. Then no one will be able to merge it but will be able to give review.

Thanks. Turned it into a draft.

@nafistiham nafistiham marked this pull request as ready for review May 2, 2023 21:20
@nafistiham nafistiham requested review from ahnafyy and moshfiqrony May 2, 2023 21:20
@nafistiham nafistiham changed the title WIP-thinking-in-react May 2, 2023
Comment thread src/content/learn/thinking-in-react.md Outdated
Comment thread src/content/learn/thinking-in-react.md Outdated
Comment thread src/content/learn/thinking-in-react.md Outdated
Comment thread src/content/learn/thinking-in-react.md Outdated
Comment thread src/content/learn/thinking-in-react.md

@nomandhoni-cs nomandhoni-cs left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nafistiham Bhai, Thanks again for an amazing translation. 👏
I added an word, I guess you missed that. I am approving this PR.

Comment thread src/content/learn/thinking-in-react.md Outdated
@nafistiham nafistiham added this pull request to the merge queue May 4, 2023
Merged via the queue into reactjs:main with commit 29b59e5 May 4, 2023
@nafistiham nafistiham deleted the thinking-in-react branch May 4, 2023 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants