Translating react dom server#110
Merged
Merged
Conversation
icarlossz
suggested changes
Feb 6, 2019
icarlossz
left a comment
icarlossz
left a comment
Contributor
There was a problem hiding this comment.
Hey, thanks! I left you some comments.
Contributor
Author
|
@icarlossz thanks for the observations. done! |
alejandronanez
approved these changes
Feb 7, 2019
alejandronanez
left a comment
alejandronanez
left a comment
Contributor
There was a problem hiding this comment.
Hey @devrchancay, thanks for your contribution - and congratulations on your first PR!
This is looking good! I'm gonna merge it right away!
Thanks @icarlossz for the review :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Translation of API Reference for ReactDOM
Related: Original issue: Spanish Translation Progress
To Do: