Translate: React without ES6#118
Merged
carburo merged 17 commits intoFeb 7, 2019
Merged
Conversation
carburo
requested changes
Feb 7, 2019
carburo
left a comment
carburo
left a comment
Member
There was a problem hiding this comment.
Hi @adielhercules. Welcome!
I made some corrections and suggetions that I think should be addressed before merging.
Thank you for your contribution!
change plana -> simple (as suggested) Co-Authored-By: adielhercules <jadher.11x2@gmail.com>
change es definido -> se define (as suggested) Co-Authored-By: adielhercules <jadher.11x2@gmail.com>
change pasado a createReactClass -> que se le pasa (as suggested) Co-Authored-By: adielhercules <jadher.11x2@gmail.com>
change linea -> línea (as suggested) Co-Authored-By: adielhercules <jadher.11x2@gmail.com>
change event handler -> *event handler* (as suggested) Co-Authored-By: adielhercules <jadher.11x2@gmail.com>
change funciones de flecha -> funciones flecha (as suggested) Co-Authored-By: adielhercules <jadher.11x2@gmail.com>
change correaran -> se ejecutan (as suggested) Co-Authored-By: adielhercules <jadher.11x2@gmail.com>
change tu aun -> aun (as suggested) Co-Authored-By: adielhercules <jadher.11x2@gmail.com>
change tu debes -> debes (as suggested) Co-Authored-By: adielhercules <jadher.11x2@gmail.com>
change typos (as suggested) Co-Authored-By: adielhercules <jadher.11x2@gmail.com>
Contributor
Author
|
@carburo perfect, I already pushed all the suggestions! Thanks |
Contributor
Author
|
Oh it seems that I still have a few suggestions pending to be fixed, let me fix that. |
change on sentence about properties binding (as suggested) Co-Authored-By: adielhercules <jadher.11x2@gmail.com>
change parts on sentence about performance when using `.bind` explicitly (as suggested) Co-Authored-By: adielhercules <jadher.11x2@gmail.com>
change on sentence about boilerplate alternative (as suggested) Co-Authored-By: adielhercules <jadher.11x2@gmail.com>
change to fix typo (as suggested) Co-Authored-By: adielhercules <jadher.11x2@gmail.com>
change to fix typo (as suggested) Co-Authored-By: adielhercules <jadher.11x2@gmail.com>
change to fix typos on experimental warning (as suggested) Co-Authored-By: adielhercules <jadher.11x2@gmail.com>
carburo
approved these changes
Feb 7, 2019
Member
|
Ok, I think we are good to go. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Translate: React without ES6
Reference to #109