Skip to content

Translate: Basics > Forms#132

Merged
carburo merged 7 commits into
reactjs:masterfrom
Darking360:es-forms
Feb 15, 2019
Merged

Translate: Basics > Forms#132
carburo merged 7 commits into
reactjs:masterfrom
Darking360:es-forms

Conversation

@Darking360

@Darking360 Darking360 commented Feb 9, 2019

Copy link
Copy Markdown
Contributor

Translation of Basics: Forms

Related: Original issue: Spanish Translation Progress

To Do:

  • Finish first translation draft

  • Check translation

  • Check grammar and orthography

  • Submit final

@tesseralis

Copy link
Copy Markdown
Contributor

@Darking360 are you ready for a review? They might be able to help you with grammar, that's what reviews are for :)

@Darking360

Copy link
Copy Markdown
Contributor Author

Greetings @tesseralis I'm correcting some orthography issues and accents left in the way, and reading it again before submitting it for review. As soon as I have something solid for you guys to read I'll update the PR 💪

I'll work on this the next hour or so 🚀

@Darking360 Darking360 changed the title [WIP] Translate: Basics > Forms Feb 15, 2019
@Darking360

Copy link
Copy Markdown
Contributor Author

Greetings! 🌞

I just finished this translation, I was checking some spelling and accents, if some of you can take a look 🙏 Also something that bothers my mind a little, is regarding the word input I didn't see it in the translation style guide, but even so I translated it in the parts where it make sense to translate it, and left it as input in one paragraph I think, so please be careful when reading it 💪

Let me know if anything changes. Thanks a lot! 🚀

CC: @alejandronanez @carburo @dmoralesm

@carburo carburo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, great job! I just fixed a few typos and made one or two style recommendations. Take a look!

Comment thread content/docs/forms.md Outdated
Comment thread content/docs/forms.md Outdated
Comment thread content/docs/forms.md Outdated
Comment thread content/docs/forms.md Outdated
Comment thread content/docs/forms.md Outdated
Comment thread content/docs/forms.md Outdated
Comment thread content/docs/forms.md Outdated
Comment thread content/docs/forms.md Outdated
Comment thread content/docs/forms.md Outdated
Comment thread content/docs/forms.md Outdated
@Darking360

Copy link
Copy Markdown
Contributor Author

Hey @carburo thanks for the amazing review, as usual! 👊 🎊

I just added your feedback, and thanks for the suggestions 🚀 If you could take a look again 🙏

Thanks a lot once more! 💯

CC: @dmoralesm @alejandronanez

@carburo

carburo commented Feb 15, 2019

Copy link
Copy Markdown
Member

Thank you! I'm merging it. And welcome as to the crew of maintainers!

@carburo carburo merged commit 157ef5a into reactjs:master Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment