Skip to content

Translate Hooks FAQ#151

Merged
alejandronanez merged 12 commits into
reactjs:masterfrom
caal-15:master
Feb 26, 2019
Merged

Translate Hooks FAQ#151
alejandronanez merged 12 commits into
reactjs:masterfrom
caal-15:master

Conversation

@caal-15

@caal-15 caal-15 commented Feb 13, 2019

Copy link
Copy Markdown

Translated:

  • Index
  • First Section.
@alejandronanez alejandronanez self-requested a review February 17, 2019 20:33
@netlify

netlify Bot commented Feb 20, 2019

Copy link
Copy Markdown

Deploy preview for es-reactjs ready!

Built with commit bbc2e9b

https://deploy-preview-151--es-reactjs.netlify.com

Comment thread content/docs/hooks-faq.md Outdated
Comment thread content/docs/hooks-faq.md Outdated
Comment thread content/docs/hooks-faq.md
Comment thread content/docs/hooks-faq.md Outdated

@icarlossz icarlossz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks! I left you some comments related to accents and typos.

Comment thread content/docs/hooks-faq.md Outdated
Comment thread content/docs/hooks-faq.md Outdated
Comment thread content/docs/hooks-faq.md Outdated
Comment thread content/docs/hooks-faq.md
Comment thread content/docs/hooks-faq.md Outdated
Comment thread content/docs/hooks-faq.md Outdated
Comment thread content/docs/hooks-faq.md Outdated
Comment thread content/docs/hooks-faq.md Outdated
Comment thread content/docs/hooks-faq.md Outdated
Comment thread content/docs/hooks-faq.md Outdated
@caal-15

caal-15 commented Feb 20, 2019

Copy link
Copy Markdown
Author
  • Componentes

Can you point me at the line where you found the mistake?

Comment thread content/docs/hooks-faq.md Outdated

@alejandronanez alejandronanez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there @caal-15, welcome to the project, and thanks for your first-time contribution!

This PR is looking really good, thanks for all the effort. I left some comments that are worth addressing before merging this work.

Please, let me know if you have any question or if you need any help!

Comment thread content/docs/hooks-faq.md Outdated
Comment thread content/docs/hooks-faq.md
Comment thread content/docs/hooks-faq.md Outdated
Comment thread content/docs/hooks-faq.md Outdated
Comment thread content/docs/hooks-faq.md Outdated
Comment thread content/docs/hooks-faq.md Outdated
@alejandronanez alejandronanez changed the title WIP: Translate Hooks FAQ Feb 21, 2019
@alejandronanez

Copy link
Copy Markdown
Contributor

Hey @caal-15, heads up, there are some merge conflicts that you have to resolve before merging!

@caal-15

caal-15 commented Feb 25, 2019

Copy link
Copy Markdown
Author

Hey everyone!, I have fixed the merge conflicts and added @alejandronanez's suggestions, I can add the las section today so we have the whole thing ready for a final review :D

@icarlossz icarlossz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I left you some comments, thanks.

Comment thread content/docs/hooks-faq.md Outdated
Comment thread content/docs/hooks-faq.md Outdated
Comment thread content/docs/hooks-faq.md
Comment thread content/docs/hooks-faq.md Outdated
Comment thread content/docs/hooks-faq.md Outdated
Comment thread content/docs/hooks-faq.md Outdated

@alejandronanez alejandronanez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @caal-15, so close!

Left some minor comments that we should be addressed before merging!

Looking great so far, thanks for all your patience and hard work here 💪 !

Comment thread content/docs/hooks-faq.md
Comment thread content/docs/hooks-faq.md Outdated

@alejandronanez alejandronanez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @caal-15, thanks for the big effort 🙌 !

@alejandronanez alejandronanez merged commit b6b3a6a into reactjs:master Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment