Skip to content

Translate faq-versioning to spanish#154

Merged
Darking360 merged 14 commits into
reactjs:masterfrom
alejandrogarciasalas:patch-1
Feb 16, 2019
Merged

Translate faq-versioning to spanish#154
Darking360 merged 14 commits into
reactjs:masterfrom
alejandrogarciasalas:patch-1

Conversation

@alejandrogarciasalas

Copy link
Copy Markdown
Contributor

There's a few words that I am not 100% sure about the translation, some of those are:

  • breaking changes
  • major/minor version
  • package

I tried to be consistent as much as possible. I also changed the link that pointed to the english version of the semver docs to the one in spanish.

There's a few words that I am not 100% sure about the translation, some of those are:
* breaking changes
* major/minor version
* package

I tried to be consistent as much as possible. I also changed the link that pointed to the english version of the semver docs to [the one in spanish](https://semver.org/lang/es/).

@Darking360 Darking360 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greetings @alejandrogarciasalas I hope you doing well! 💪

Congratulations on your first contribution to the translation of React, we appreciate it a lot 🚀 I just finshed reading the PR, great job! I just added some word changes for your concerns about major/minor versions, for example those would end up being versión importante and versión menor respectively, breaking changes would be cambios con rupturas and finally package ends up being paquete. I left you comments for must of these, some other word changes to make the reading more understandable and easy, and a note of a little piece that wasn't translated yet, and some recommendations 👌

So please read all, fix those, check that everything was translated and update the PR 🖖 Let me know any questions or when you're done. Thanks a lot again! 🥇

Comment thread content/docs/faq-versioning.md Outdated
Comment thread content/docs/faq-versioning.md Outdated
Comment thread content/docs/faq-versioning.md Outdated
Comment thread content/docs/faq-versioning.md Outdated
Comment thread content/docs/faq-versioning.md Outdated
Comment thread content/docs/faq-versioning.md Outdated
Comment thread content/docs/faq-versioning.md Outdated
Comment thread content/docs/faq-versioning.md Outdated
Comment thread content/docs/faq-versioning.md Outdated
Comment thread content/docs/faq-versioning.md Outdated
Darking360 and others added 7 commits February 16, 2019 10:58
Co-Authored-By: alejandrogarciasalas <garciasalasalejandro@gmail.com>
Co-Authored-By: alejandrogarciasalas <garciasalasalejandro@gmail.com>
Co-Authored-By: alejandrogarciasalas <garciasalasalejandro@gmail.com>
Co-Authored-By: alejandrogarciasalas <garciasalasalejandro@gmail.com>
Co-Authored-By: alejandrogarciasalas <garciasalasalejandro@gmail.com>
Co-Authored-By: alejandrogarciasalas <garciasalasalejandro@gmail.com>
Co-Authored-By: alejandrogarciasalas <garciasalasalejandro@gmail.com>
Darking360 and others added 4 commits February 16, 2019 11:05
Co-Authored-By: alejandrogarciasalas <garciasalasalejandro@gmail.com>
Co-Authored-By: alejandrogarciasalas <garciasalasalejandro@gmail.com>
@alejandrogarciasalas

Copy link
Copy Markdown
Contributor Author

Gracias @Darking360 ! Todo listo.
Let me know if there's anything else missing.

@Darking360 Darking360 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one detail left 😅

Comment thread content/docs/faq-versioning.md Outdated
Co-Authored-By: alejandrogarciasalas <garciasalasalejandro@gmail.com>
@alejandrogarciasalas

Copy link
Copy Markdown
Contributor Author

listo y gracias de nuevo!

@Darking360 Darking360 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect @alejandrogarciasalas ! Just fix 3 more issues that I didn't see before 🚀 Great work! Welcome aboard 💪

Comment thread content/docs/faq-versioning.md Outdated
Comment thread content/docs/faq-versioning.md Outdated
Comment thread content/docs/faq-versioning.md Outdated
Fixing last 3 issues.
@alejandrogarciasalas

Copy link
Copy Markdown
Contributor Author

done ✅

@Darking360 Darking360 merged commit 778f2c2 into reactjs:master Feb 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment