More warnings#81
Merged
Merged
Conversation
alejandronanez
suggested changes
Feb 6, 2019
alejandronanez
left a comment
alejandronanez
left a comment
Contributor
There was a problem hiding this comment.
Hello @jvelezpo, thanks for your contribution!
I left some comments here, to sum up:
- Please, roll back the changes made to the warning messages. Since React does not provide any translated messages, having them in another language different than English could confuse people.
- Change the wording from
ustedtotú👍
Let us know when this is ready for review again!
Thanks!
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
Co-Authored-By: jvelezpo <jvelezpo@users.noreply.github.com>
Contributor
Author
|
@alejandronanez done with the changes 👍 |
alejandronanez
approved these changes
Feb 7, 2019
alejandronanez
left a comment
alejandronanez
left a comment
Contributor
There was a problem hiding this comment.
Thanks for all these changes!
Merging it 
!
| return function validate(props, propName, componentName) { | ||
| if (props[propName] != null) { | ||
| const message = `"${propName}" propiedad de "${componentName}" ha sido desaprobado.\n${explanation}`; | ||
| const message = `"${propName}" property of "${componentName}" has been deprecated.\n${explanation}`; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warnings
Relates to: #79