Translate: Fragments#82
Conversation
elyalvarado
left a comment
elyalvarado
left a comment
There was a problem hiding this comment.
Hey @RamirezAlex some suggestions
|
Thanks @elyalvarado. I did the proper fixes you suggested. |
alejandronanez
left a comment
alejandronanez
left a comment
There was a problem hiding this comment.
Hey @RamirezAlex, thanks for wrapping this up!
The only big change I think we should do here, is to change the code back to English.
Besides that, everything looks 👍
| <div> | ||
| <td>Hello</td> | ||
| <td>World</td> | ||
| <td>Hola</td> |
There was a problem hiding this comment.
Hey @RamirezAlex, we're leaving the code as is, we're only translating comments. So please, leave this as <td>Hello</td>
We use lots of codepen examples, and if we translate the code contents we could confuse people!
| <dl> | ||
| {props.items.map(item => ( | ||
| // Without the `key`, React will fire a key warning | ||
| // Sin la 'key', React disparará una advertencia de key |
There was a problem hiding this comment.
Maybe this could sound better as
| // Sin la 'key', React disparará una advertencia de key | |
| // Sin el prop 'key', React disparará una advertencia de key |
alejandronanez
left a comment
alejandronanez
left a comment
There was a problem hiding this comment.
Fragments should be renamed to Fragmentos :)
|
Thank you @alejandronanez I updated the PR. |
3 participants
This is related to #80
Please review.