Skip to content

Backport fatal connection attempt handling to 0.216.x#390

Merged
jackyzha0 merged 1 commit into
brn-backport-0.216.2from
jacky/fatal-connection-attempt-216
Jun 26, 2026
Merged

Backport fatal connection attempt handling to 0.216.x#390
jackyzha0 merged 1 commit into
brn-backport-0.216.2from
jacky/fatal-connection-attempt-216

Conversation

@jackyzha0

Copy link
Copy Markdown
Member

Why

@replit/river@0.219.0 includes the fatal connection-attempt fix, but repl-it-web cannot consume it yet because pid2 still uses the 0.216.x River/@sinclair/typebox service type surface. This backports the same retry decision behavior to the 0.216.x maintenance branch.

What changed

  • Pass the initial connection failure error into onConnectingFailed.
  • Let onConnectingFailed delete the no-connection session and stop reconnecting when isFatalConnectionError returns true.
  • Bump package metadata to 0.216.3.
  • Add a regression test for fatal initial connection attempts.

Test plan

  • direnv exec . npm exec -- vitest run __tests__/negative.test.ts
  • direnv exec . npm run check
  • direnv exec . npm exec -- vitest run
@jackyzha0 jackyzha0 marked this pull request as ready for review June 26, 2026 22:26
@jackyzha0 jackyzha0 requested a review from a team as a code owner June 26, 2026 22:26
@jackyzha0 jackyzha0 requested review from darshkpatel and removed request for a team June 26, 2026 22:26
@jackyzha0 jackyzha0 merged commit c37a838 into brn-backport-0.216.2 Jun 26, 2026
3 checks passed
@jackyzha0 jackyzha0 deleted the jacky/fatal-connection-attempt-216 branch June 26, 2026 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants