Fix rewatch panic when package.json has no "name" field#8291
Merged
Conversation
nojaf
reviewed
Mar 12, 2026
cknitt
force-pushed
the
fix-rewatch-panic
branch
2 times, most recently
from
69e7008 to
11ad226
Compare
nojaf
reviewed
Mar 12, 2026
| let contents = fs::read_to_string(&rescript_json_path) | ||
| .map_err(|e| anyhow!("Could not read rescript.json: {}", e))?; | ||
| let json: serde_json::Value = | ||
| serde_json::from_str(&contents).map_err(|e| anyhow!("Could not parse rescript.json: {}", e))?; |
Member
There was a problem hiding this comment.
I'm not sure the changes in read_package_name bring anything new here?
Seems like a rewrite just for fun.
Notice how the original code had the file_name in .map_err(|e| anyhow!("Could not parse {}: {}", file_name, e))?;, in this version you no longer have this.
The real fix in is in make_package.
Member
Author
There was a problem hiding this comment.
read_package_name still needs a change because without a change, this case still fails:
- package.json exists
- package.json has no name
- rescript.json does have name
The make_package change only fixes the panic.
cknitt
force-pushed
the
fix-rewatch-panic
branch
from
11ad226 to
5dc5618
Compare
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
nojaf
approved these changes
Mar 12, 2026
nojaf
pushed a commit
to nojaf/rescript
that referenced
this pull request
Mar 16, 2026
…g#8291) * Fix rewatch panic when package.json has no "name" field * CHANGELOG
cknitt
added a commit
that referenced
this pull request
May 16, 2026
* Fix rewatch panic when package.json has no "name" field * CHANGELOG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix rewatch panic when package.json has no "name" field
Fixes #8184
Problem
Rewatch panicked when
package.jsonexisted but lacked a "name" field, even thoughrescript.jsoncontained the name. This occurred in CI's installation test wherenpm icreates apackage.jsonwithout a name field.Solution
Modified
read_package_nameto fall back torescript.jsonwhenpackage.jsonhas no "name" field, instead of immediately erroring.package.jsonfirst for "name" fieldrescript.jsonTesting
Removed
tests/package_tests/installation_test/package.jsonto restore the original test scenario (no package.json, name read from rescript.json). Verified build succeeds in this configuration.Added a
rewatchunit test for the remaining error path where bothpackage.jsonandrescript.jsonexist but neither contains anamefield.