Fix rewatch transitive local workspace detection#8411
Merged
fhammerschmidt merged 2 commits intoMay 6, 2026
Merged
Conversation
Signed-off-by: Florian Hammerschmidt <florianh89@gmail.com>
Signed-off-by: Florian Hammerschmidt <florianh89@gmail.com>
jfrolich
approved these changes
May 6, 2026
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
cknitt
pushed a commit
that referenced
this pull request
May 6, 2026
* Fix rewatch transitive local workspace detection Signed-off-by: Florian Hammerschmidt <florianh89@gmail.com> * Add changelog entry for rewatch workspace fix Signed-off-by: Florian Hammerschmidt <florianh89@gmail.com> --------- Signed-off-by: Florian Hammerschmidt <florianh89@gmail.com> # Conflicts: # CHANGELOG.md # rewatch/src/build/packages.rs
cknitt
pushed a commit
that referenced
this pull request
May 16, 2026
* Fix rewatch transitive local workspace detection Signed-off-by: Florian Hammerschmidt <florianh89@gmail.com> * Add changelog entry for rewatch workspace fix Signed-off-by: Florian Hammerschmidt <florianh89@gmail.com> --------- Signed-off-by: Florian Hammerschmidt <florianh89@gmail.com> # Conflicts: # CHANGELOG.md # rewatch/src/build/packages.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix rewatch's local workspace detection for monorepo roots so transitive workspace dependencies are treated as local packages.
Previously, when building from a monorepo root, rewatch only marked dependencies as local if their package names appeared directly in the root
rescript.jsondependencies or dev-dependencies. This missed local workspace packages that were only reached transitively, even though they resolve to paths inside the workspace.The new logic classifies monorepo-root dependencies by their resolved canonical path, matching the existing monorepo-package behavior: packages inside the workspace root and outside
node_modulesare local.Why
This affects root-level monorepo builds and analysis workflows. Transitive local workspaces should be:
.sourcedirs.jsoncmt_scanplan consumed by reanalyzeWithout this, root-level
rescript-tools reanalyzecan miss CMT files for transitive local workspaces in monorepos.