fix(deps): relax opencv-python-headless pin to >=4.10.0#501
Open
davidnichols-ops wants to merge 1 commit into
Open
fix(deps): relax opencv-python-headless pin to >=4.10.0#501davidnichols-ops wants to merge 1 commit into
davidnichols-ops wants to merge 1 commit into
Conversation
The exact pin opencv-python-headless==4.10.0.84 causes dependency conflicts for downstream consumers who need a different opencv version. Relax to a minimum-version range, consistent with other deps in requirements.txt. Verified passing with both 4.10.0.84 and 4.13.0.92.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
davidnichols-ops
force-pushed
the
fix/opencv-pin-relax-349
branch
from
38a11c1 to
1bb9a83
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
opencv-python-headless==4.10.0.84pin inrequirements.txttoopencv-python-headless>=4.10.0, unblocking downstream consumers from using a different opencv version without resolver conflicts.setup.pyreadsinstall_requiresfromrequirements.txt, so no other files need changes.desktopextra insetup.py(opencv-python==4.8.0.74) is intentionally left as-is — it's an opt-in extra, not the default install path.Closes #349. Related to #365 (consumers requesting full opencv instead of headless — this pin relaxation reduces the conflict surface for that use case).
Test plan
git diffshows only the one-line requirements changepython -m unittestpasses — 729 tests, OK (skipped=1) with opencv-python-headless 4.10.0.84python -m unittestpasses — 729 tests, OK (skipped=1) with opencv-python-headless 4.13.0.92 (latest)pip install -e .resolves successfully under the relaxed range