add support for historical balances query#11749
Open
prettyirrelevant wants to merge 1 commit intorotki:developfrom
Open
add support for historical balances query#11749prettyirrelevant wants to merge 1 commit intorotki:developfrom
prettyirrelevant wants to merge 1 commit intorotki:developfrom
Conversation
prettyirrelevant
force-pushed
the
improve-historical-balances
branch
from
70c4670 to
415a33d
Compare
| ) | ||
| assets = tuple(Asset(row[0]) for row in cursor) | ||
|
|
||
| processing_required, amounts = HistoricalBalancesManager(self.rotkehlchen.data.db).get_assets_amounts_event_metrics( # noqa: E501 |
Contributor
There was a problem hiding this comment.
the get_assets_amounts_event_metrics function also needs removed now I guess.
Maybe I missed some of the discussion on this, but it looks like maybe the event_metrics table is not going to be used after all? will it be removed in another pr I guess? or are you still going to use that for something?
Contributor
Author
There was a problem hiding this comment.
removed get_assets_amounts_event_metrics. the table will still be useful, but for the reconciliation task, which is separate from what this pr does.
the tldr is that historical balance queries will be done on-demand, and only events matching the provided query will be used in the calculation
prettyirrelevant
force-pushed
the
improve-historical-balances
branch
from
415a33d to
7398329
Compare
prettyirrelevant
force-pushed
the
improve-historical-balances
branch
from
7398329 to
ecd5730
Compare
nicholasyoder
added
the
ready for final review
yabirgb
added
considering how to proceed
and removed
ready for final review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.