Allow override Redis host/port/prefix via defines#152
Merged
chandrapatel merged 3 commits intortCamp:masterfrom Sep 20, 2018
vincent-lu:master
Merged
Allow override Redis host/port/prefix via defines#152chandrapatel merged 3 commits intortCamp:masterfrom vincent-lu:master
chandrapatel merged 3 commits intortCamp:masterfrom
vincent-lu:master
Conversation
Contributor
Author
|
Ping @chandrapatel , thanks for the great work, again. |
|
Testing this PR. |
Contributor
Author
|
Thanks @mbtamuli let me know if you have any suggestions for this PR. |
|
Tested this PR. This changes made in this PR works perfectly as intended. |
chandrapatel
approved these changes
Sep 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal is to allow defining Redis cache's host/port/prefix without using nginx helper's settings backend page. The three defines are:
If not defined, everything works as is (fallback to the settings stored in options, if empty, fallback to 127.0.0.1/6379/nginx-cache:
If defined, the input fields for the predefined redis settings are disabled, with note underneath to inform the user this field is overridden by defines.
Documentation (FAQ in README.md) is updated to reflect this feature.
The main benefit of this is in multiple server situations (production vs staging, load balanced servers, etc) you don't have to rely on database to inform nginx helper about where to find the redis server.
Thanks and please consider this PR.