postpos readpreceph: omit alloc and free of the sbas ephemeris#251
Merged
rtklibexplorer merged 1 commit intortklibexplorer:demo5from Dec 16, 2024
Merged
Conversation
readpreceph() and freepreceph() need not allocate and free the sbas ephemeris as this is done by readobsnav() and freeobsnav(), and readobsnav() was overwriting the data structures setup by readpreceph() without freeing them leading a loss of memory.
ourairquality
force-pushed
the
readpreceph-omit-seph
branch
from
b5e06d3 to
f10fa74
Compare
Author
|
Fwiw this should be a safe PR to merge, and quietens a loss of memory warning. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
readpreceph() and freepreceph() need not allocate and free the sbas ephemeris as this is done by readobsnav() and freeobsnav(), and readobsnav() was overwriting the data structures setup by readpreceph() without freeing them leading a loss of memory.