postpos inputobs: guard against iobsr being out of range#253
Merged
rtklibexplorer merged 1 commit intortklibexplorer:demo5from Dec 14, 2024
Merged
Conversation
ourairquality
force-pushed
the
inputobs-guard-iobsr
branch
from
7560631 to
63ffa1c
Compare
The iobsr index can be out of range of the obs data, beyond the end or the start, such as when there is only one receiver. inputobs() was indexing into the data using the out of range iobsr index. Remove a redundant call to nextobsf() in the case that an immediate prior call returned zero. Small performance improvement for nextobsf() and nextobsb(). Avoid comparing the obs times if an obs with a different rcv is found first.
ourairquality
force-pushed
the
inputobs-guard-iobsr
branch
from
63ffa1c to
dff03a1
Compare
rtklibexplorer
added a commit
that referenced
this pull request
Dec 15, 2024
…d up the normal merge process so am manually adding the code. The iobsr index can be out of range of the obs data, beyond the end or the start, such as when there is only one receiver. inputobs() was indexing into the data using the out of range iobsr index. Remove a redundant call to nextobsf() in the case that an immediate prior call returned zero. Small performance improvement for nextobsf() and nextobsb(). Avoid comparing the obs times if an obs with a different rcv is found first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The iobsr index can be out of range of the obs data, beyond the end or the start, such as when there is only one receiver. inputobs() was indexing into the data using the out of range iobsr index.
Remove a redundant call to nextobsf() in the case that an immediate prior call returned zero.
Small performance improvement for nextobsf() and nextobsb(). Avoid comparing the obs times if an obs with a different rcv is found first.