Fix convbin only outputting the last SBF observation#670
Merged
JensReimann merged 1 commit intortklibexplorer:demo5from Jun 24, 2025
Merged
Fix convbin only outputting the last SBF observation#670JensReimann merged 1 commit intortklibexplorer:demo5from
JensReimann merged 1 commit intortklibexplorer:demo5from
Conversation
Previously, rtkconv could output only the last SBF observation. During conversion, the process would decode the same observation file twice. On the second pass, it would first read the last observation from the buffer in [sbf](src/rcv/septentrio.c:706). This caused [convrnx](src/convrnx.c:1043-1045) to reject all observations that were not newer than the last one, resulting in missing data.
|
This and many other fixes were in #503 but that depended on yet other changes and still seems a way off. Might be wasting time to revisit all the issues. |
Author
|
I looked through #503 and saw that it does cover this and many other fixes. Since it’s still pending and seems like a larger change set, maybe landing small, targeted fixes like this one could help keep things working in the meantime? |
Collaborator
|
As ourairquality pointed out, #503 depends, unfortunately, on many other changes. If we could separate the sbf related changes I would be more then willing to merge them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, rtkconv could output only the last SBF observation. During conversion, the process would decode the same observation file twice. On the second pass, it would first read the last observation from the buffer in sbf. This caused convrnx to reject all observations that were not newer than the last one, resulting in missing data.