gui console output cleanup#687
Merged
JensReimann merged 1 commit intortklibexplorer:demo5from Jun 24, 2025
Merged
Conversation
A few functions use similar code to output stream ASCII or hex to a console. The code was adding linefeeds to wrap lines and then detecting these, and also leaving them which was noise in most cases. This reworks the code to avoid these trailing linefeeds. rtknavi_qt was initializing the stream console output checkbox to 'HEX' but the initial output was ASCII.
ourairquality
force-pushed
the
gui-add-console
branch
from
94ecd5e to
5d6a30f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few functions use similar code to output stream ASCII or hex to a console. The code was adding linefeeds to wrap lines and then detecting these, and also leaving them which was noise in most cases. This reworks the code to avoid these trailing linefeeds.
rtknavi_qt was initializing the stream console output checkbox to 'HEX' but the initial output was ASCII.
TODO Noticed that the qt app uses a proportional font for this console output which does not present well for the HEX output and also some of the other output presents better in a mono-space font as used in the windows gui apps.