rtkplot: add sky and DOP plots using the solution stat input#713
Merged
JensReimann merged 2 commits intortklibexplorer:demo5from Jul 19, 2025
Merged
Conversation
ourairquality
force-pushed
the
rtkplot-sol-stat-sky-dop
branch
2 times, most recently
from
cff6ef9 to
fec6a1f
Compare
JensReimann
reviewed
Jul 6, 2025
| int xi = 0; | ||
| for (; xi < n; xi++) | ||
| if (fabs(x[xi] - xp) < 0.001) break; | ||
| if (xi >= n) xi = n - 1; |
Collaborator
There was a problem hiding this comment.
If n is 0, xi becomes -1 causes an invalid access in line 2170 (happened to me).
I suggest to check if n is <= 0 already line 2117 and leave the routine already there.
Author
There was a problem hiding this comment.
Thank you, should be fixed now. The windows gui app support has also been added and appears to work too - there was an issue with the sorting of the solution stat data which was being reordered by the windows qsort implementation and which broke assumptions in this new code and a fix for that is also included.
ourairquality
force-pushed
the
rtkplot-sol-stat-sky-dop
branch
2 times, most recently
from
233ee1d to
f4e7cae
Compare
The solution stat file has the satellites used in the solution and the satellite azimuth and elevation which is a usable input for these plots, and without loading the observation and navigation data. It also gives the data used in the solution. These are added as additional plots to the current observation data based sky and DOP plot which are still useful when examining this data and planning solutions.
This allows the user of the data to assume this ordering, to assume that the satellite frequencies are at least grouped together. This is also the ordering in which the data is emitted.
ourairquality
force-pushed
the
rtkplot-sol-stat-sky-dop
branch
from
f4e7cae to
f92413f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In part prompted by the discussion in #712 This is for the Qt rtkplot, but can have a look at windows app support if this is considered useful.
The solution stat file has the satellites used in the solution and the satellite azimuth and elevation which is a usable input for these plots, and without loading the observation and navigation data. It also gives the data used in the solution. These are added as additional plots to the current observation data based sky and DOP plot which are still useful when examining this data and planning solutions.