Suppress irb_info measures ambiguous_width in command test#1074
Merged
Conversation
Merged
Member
|
This is great 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some test in
test/irb/test_command.rb,irb_infomeasures ambiguous width by unicode character"\u{25bd}"and escape sequence"\e[6n".It is used here.
This pull request suppresses it.
Actual problem
When running
rake testthrough this command,▽^[3;1Rwill be displayed in terminal screen for about 0.5 second.When running
rake testthrough this command in tty terminal, test hangs up with▽displayed in terminal screen.This is because
STDIN.rawhangs up for unknown reason.The latter one that uses
spawnwithpgroup: truewas used inruby/ruby'stool/test-bundled-gems.rb.https://github.com/ruby/ruby/blob/dd863714bf377b044645ea12b4db48920d49694e/tool/test-bundled-gems.rb#L82
It looks like ci passes because it runs in non-tty environment. (Reline::IOGate is Reline::Dumb)