Skip to content

Fix a few inconsistencies in the README#1045

Merged
byroot merged 1 commit into
ruby:masterfrom
duffuniverse:update-json-docs
Jun 27, 2026
Merged

Fix a few inconsistencies in the README#1045
byroot merged 1 commit into
ruby:masterfrom
duffuniverse:update-json-docs

Conversation

@duffuniverse

@duffuniverse duffuniverse commented Jun 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Detail

  • Add the missing strict: true option to the JSON.generate call in the code example.
  • Update the JSON::Coder example.
byroot
byroot reviewed Jun 26, 2026
View reviewed changes
Comment thread README.md

```ruby
module MyApp
API_JSON_CODER = JSON::Coder.new do |object, is_object_key|

@byroot byroot Jun 26, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep the second argument.
byroot
byroot reviewed Jun 26, 2026
View reviewed changes
Comment thread README.md Outdated

```ruby
coder = JSON::Combining.new do |object, is_object_key|
coder = JSON::Coder.new do |object|

@byroot byroot Jun 26, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.
@byroot byroot force-pushed the update-json-docs branch from 6b399b3 to 351a550 Compare June 27, 2026 06:17
@byroot byroot merged commit faa5572 into ruby:master Jun 27, 2026
@duffuniverse duffuniverse deleted the update-json-docs branch June 27, 2026 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@duffuniverse @byroot