🥅 Fix premature tagged response guard for IDLE - #688
Merged
Conversation
The premature tagged `OK` response guard that was added for `STARTTLS`, in #664, didn't correctly drop the connection when it was triggered for `IDLE`. Note that `finish_command` was moved until _after_ sending the command, so the raised error would be consistent with all other commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The premature tagged
OKresponse guard that was added forSTARTTLS, in #664, didn't correctly drop the connection when it was triggered forIDLE.Note that
finish_commandwas moved until after sending the command, so the raised error would be consistent with all other commands.Note that, although this code was added for hardening against a class of security vulnerability, failing to protect against this for
IDLEis not considered a security vulnerability. If the server wants to cancelIDLEprematurely, it can still do that. Arguably, it should not be allowed to do that, because sending a tagged response for a command with an outstanding continuation request puts the connection into a weird state. Nevertheless, several very popular email servers do just that.