♻️ Extract handle_response from receive_responses - #695
Merged
nevans merged 1 commit intoJun 8, 2026
Conversation
`connection_closed` was only assigned by this portion of the loop, so it's been converted into the return value, and the loop is now a simple `Kernel#loop`. The `receive_responses` method returns when `handle_response` returns falsey.
nevans
commented
Jun 8, 2026
| @exception = nil unless connection_closed | ||
| end | ||
| end | ||
| handle_response(resp) or return |
Collaborator
Author
There was a problem hiding this comment.
It would make sense to convert this boolean loop breaker into a throw or raise. But the caveat is that we still need to reset @exception after handling an exception that doesn't closing the connection. So we'd still need to track that inside handle_response.
nevans
deleted the
refactor-extract-handle_response-from-receive_responses
branch
June 8, 2026 14:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracting
handle_responsemakes thereceive_responsesmuch easier to read, IMO. Also, this block of code has been surrounded by a redundantbegin/end, since #694 pulled therescueclause inside thesynchronizeblock.connection_closedwas only assigned by this portion of the loop, so it's been converted into the inverse of the return value forhandle_response, and the loop is now a simpleKernel#loop. Thereceive_responsesmethod returns whenhandle_responsereturns falsey.