✅⚡ Faster tests - #714
Merged
Merged
Conversation
This seemed to reduce the `test_imap*.rb` tests time by over a second.
Ideally, we'd remove all of these `Kernel#sleep` calls from the test suite. Until then, this is simple, effective, and not flaky. This seems to cut down `test_imap*.rb` tests time by over two seconds.
This seems to cut down `test_imap*.rb` tests time by over three seconds! Ideally, we'd should either compile the commands or use TCP_CORK (on Linux). Since this is only for tests against localhost, there's little danger of slowing down throughput.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes allow the
test_imap*.rbtests to run significantly faster.On my laptop, they run over 60% faster, going from ~18 seconds down to ~11 seconds:
TCP_NODELAYin test server sockets