Remove weak/node-gyp dependency - #71
Open
swim wants to merge 2 commits into
Open
Conversation
Owner
|
You can pass an object with those functions, when you're instantiating a dynamic scraper. I feel that this is unnecessary to be baked in. Maybe a note in the readme. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running Phantom on a Windows box it defaults to requiring node-gyp. However, this is not required; please see https://github.com/amir20/phantomjs-node/tree/v1#use-it-in-windows. This should also address an old issue #2.