Conversation
Add 1 Month Interval (1M) for Historical Klines
Contributor
|
please document a bit clearer on what this pr is trying to achieve. |
Author
Binance launched the API for Vanilla Options in January: https://binance-docs.github.io/apidocs/voptions/en/#general-info |
|
What's the status of this? I would like to use the API to trade vanilla options, but this wrapper does not offer the functions mentioned by @dragosgr2 - https://binance-docs.github.io/apidocs/voptions/en/#general-info I could dedicate some time, implement it and push PR, if nobody is working on it? |
Contributor
|
@faileon further effort would be greatly appreciated. |
When end_ts is passed historical klines are fetched until Binance API returns no results. With every query start_ts is incremented. For the most part this cause one unnecessary query to Binance to be made, where start_ts is bigger than end_ts. Moreover, when fetching klines for future markets (not spot), Binance API returns an error in such condition (-1023). This makes it impossible to fetch klines for future markets when providing end_str param.
Fix passing start_ts > end_ts when fetching historical klines
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can you add the Vanilla Options API from Binance to the client?