shared/py/drums.py: Make default Kick be the one available in AMY #606
Merged
shared/py/drums.py: Make default Kick be the one available in AMY #606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AMY is currently built with pcm_tiny.h, which means the PCM presets are only available up to preset=10. Previously, the drums.py app was trying to use preset=25 for the kick drum, which resulted in a heavily down pitched maraca, which sounded bad. Here, we change the default voices for the drums.py app to be ones that are available even in "tiny" AMY.
We still have the problem that many of the alternate voices offered by the pulldown in drums.py are not going to work as expected with tiny AMY. We built drums.py expecting AMY to be compiled with pcm_small.h, but then we ran into AMY size issues for, e.g., RP2040 targets under Arduino, so we cut it back. Ideally, we'd build AMY with pcm_small when building for a Tulip target.