Replace parse_patch_number_to_events with event_generator_for_patch_number.#692
Open
Replace parse_patch_number_to_events with event_generator_for_patch_number.#692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When linked to amy:event_generator_for_synth, this patch reads AMY patches using the event generator instead of
parse_patch_number_to_events(which included a leakingcalloc).Note: At
amy_parameters.js:763, I had to changewindow.suppress_knob_cc_sendtofalse, otherwise loading the patch updated the UI but not AMY. I don't understand why this was working before the change (AFAICT, my change merely shifts around how the patches are read from memory), nor why knob sending needed to be suppressed in the past. The new setup seems to work without problems though?