Updated fill_na_rows function in clean_data.py - #24
Open
ashish-kamboj wants to merge 1 commit into
Open
Conversation
…n='both' Changed interpolate method to 'linear' and limit_direction to 'both' As with the method='pad' if index 0 value is NaN then this method won't will the index 0 value (it will remain NaN after interpolation also). Also with method='pad' we can't have limit_direction='backward' It's better to choose method='linear' and limit_direction='both' (because there will be chances that first and last index values can be NaN, it will be easily interpolated if limit_direction='both')
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed interpolate method to 'linear' and limit_direction to 'both'
As with the method='pad' if index 0 value is NaN then this method won't will the index 0 value (it will remain NaN after interpolation also). Also with method='pad' we can't have limit_direction='backward'
It's better to choose method='linear' and limit_direction='both' (because there will be chances that first and last index values can be NaN, it will be easily interpolated if limit_direction='both')