TreeSitterQuery: pass utf8 byte count to ts_query_new#419
Open
Bogdanp wants to merge 1 commit intosimonbs:mainfrom
Open
TreeSitterQuery: pass utf8 byte count to ts_query_new#419Bogdanp wants to merge 1 commit intosimonbs:mainfrom
Bogdanp wants to merge 1 commit intosimonbs:mainfrom
Conversation
Passing the Character count is problematic for query fiels that contain unicode characters (such as λ or ∀ -- as in [1]), because the Character count ends up being shorter than the byte length, leading to truncated patterns (as in the @comment at the end of [1]) or invalid syntax. [1]: https://github.com/6cdh/tree-sitter-racket/blob/56b57807f86aa4ddb14892572b318edd4bc90ebe/queries/highlights.scm#L12
Author
|
@simonbs any thoughts on this change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing the Character count is problematic for query files that contain unicode characters (such as λ or ∀ -- as in 1), because the Character count ends up being shorter than the byte length, leading to truncated patterns (as in the
@commentat the end of 1) or invalid syntax.