Https/GitHub.com/alan840706/micropython#472
Https/GitHub.com/alan840706/micropython#472alan840706 wants to merge 64 commits intosipeed:masterfrom
Conversation
vowstar
requested review from
Neutree and
junhuanchen
and removed request for
Neutree
| @@ -0,0 +1 @@ | |||
|
|
|||
There was a problem hiding this comment.
This empty file was added by mistake and needs to be cleaned up
| for (int i = 0; i < 256; i++) { | ||
| write_long_raise(file, ((i) << 16) | ((i) << 8) | i); | ||
| } | ||
| printf("OK1!\n"); |
There was a problem hiding this comment.
Need to clean up unnecessary code
| } | ||
| } | ||
| } else { | ||
| printf("OK2!\n"); |
There was a problem hiding this comment.
Need to clean up unnecessary code
| // Set pixel (handles boundary check and image type check). | ||
| void imlib_set_pixel(image_t *img, int x, int y, int p) | ||
| { | ||
| { |
There was a problem hiding this comment.
Unnecessary trailing space
| switch (arg_img->bpp) { | ||
| case IMAGE_BPP_BINARY: { | ||
| IMAGE_PUT_BINARY_PIXEL(arg_img, arg_x, arg_y, arg_c); | ||
| //printf("0"); |
There was a problem hiding this comment.
Need to clean up unnecessary code
| } | ||
| case IMAGE_BPP_GRAYSCALE: { | ||
| IMAGE_PUT_GRAYSCALE_PIXEL(arg_img, arg_x, arg_y, arg_c); | ||
| //printf("1"); |
There was a problem hiding this comment.
Need to clean up unnecessary code
| } | ||
| case IMAGE_BPP_BAYER: { | ||
| IMAGE_PUT_GRAYSCALE_PIXEL(arg_img, arg_x, arg_y, arg_c); // Correct! | ||
| //printf("3"); |
There was a problem hiding this comment.
Need to clean up unnecessary code
|
|
||
| // only MSB transfer is implemented | ||
|
|
||
There was a problem hiding this comment.
Unnecessary trailing space
| uint32_t delay_half = self->delay_half; | ||
|
|
||
| // printk("%s %d %d %d\r\n", __func__, self->pin_sck, self->pin_d[0], self->pin_d[1]); | ||
There was a problem hiding this comment.
Unnecessary trailing space
| } | ||
|
|
||
| STATIC mp_obj_t mp_machine_spi_read(size_t n_args, const mp_obj_t *pos_args, mp_map_t *kw_args) { | ||
| STATIC mp_obj_t mp_machine_spi_read(size_t n_args, const mp_obj_t *pos_args, mp_map_t *kw_args) { |
There was a problem hiding this comment.
Unnecessary trailing space
| fifo_len = spi_handle->rxflr; | ||
|
|
||
| //fifo_len = spi_handle->rxflr; | ||
| fifo_len = rx_len; |
There was a problem hiding this comment.
Please explain the specific reason for the modification here
2 participants
No description provided.